Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if test was not executed #42

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Warn if test was not executed #42

merged 1 commit into from
Jun 24, 2024

Conversation

fredrikaverpil
Copy link
Owner

@fredrikaverpil fredrikaverpil commented Jun 24, 2024

This can happen if you e.g. are using testify. Fixes #40.

Demo

fix_bug.mov

@fredrikaverpil fredrikaverpil self-assigned this Jun 24, 2024
@fredrikaverpil fredrikaverpil force-pushed the skip-tests-not-found branch 3 times, most recently from 4047cde to 8df6c93 Compare June 24, 2024 11:24
@fredrikaverpil fredrikaverpil added the bug Something isn't working label Jun 24, 2024
Copy link

@jstensland jstensland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and resolves #40 for me

@fredrikaverpil
Copy link
Owner Author

@jstensland thanks for testing (and thanks for reporting!) I'll merge this shortly together with some other minor improvements.

@fredrikaverpil fredrikaverpil enabled auto-merge (rebase) June 24, 2024 16:02
@fredrikaverpil fredrikaverpil merged commit d7c005b into main Jun 24, 2024
7 checks passed
@fredrikaverpil fredrikaverpil deleted the skip-tests-not-found branch June 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests that are not actually run are marked as passing
2 participants