Do not ignore if route is a constraint #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #discover_rack_app method is responsible for finding nested routes within the constraint
|
@fredwu let's merge it! =) |
fredwu
added a commit
that referenced
this pull request
Mar 20, 2013
Do not ignore if route is a constraint
|
Yeah! Thanks! ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found out that routes that are defined within constraint block don't get displayed in missing definitions because of this line.
Since the #discover_rack_app method looks inside the constraint for the rack app, I think this line is not necessary.
Let me know how can I improve this P.R. with tests.