Introduce ApiTaster.route_path configuration option #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fredwu,
The right way to define where we would like to use ApiTaster is to require it in the correct bundler group.
For example we usually would like to use it in the development and staging environments in the Rails application.
So make sense to require like:
In the
config/routes.rb
better to checkApiTaster
constant definition instead of define tricky logic like thisBy default Rails loader requires everything from
app
directory. So in case we are in thetest
environment for example whenapi_taster
gem does not loaded we will getuninitialized constant ApiTaster
error for sure.And for sure it will be not cool to check
ApiTaster
constant definition in each file in theapp/api_tasters/
folder.Probably better to move api tasters from
app/api_tasters
tolib/api_tasters
.So this change set implements two things:
ApiTaster.route_path
option introduced instead of hardcoded value in theRoute
classlib/api_tasters