Rails4 support which plays nice even with Rails 3 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow nice work! This is great! :) 👍 |
| @@ -36,7 +36,11 @@ module ApiTaster | |||
| before(:all) do | |||
| Rails.application.routes.draw do | |||
| resources :dummy_users do | |||
| member { map_method :patch, :update } | |||
| if ApiTaster.rails4? | |||
There was a problem hiding this comment.
Since rails4? is only used once, in the test, I reckon we should use Rails.version directly instead of having it as part of ApiTaster. wdyt?
fredwu
added a commit
that referenced
this pull request
Oct 11, 2013
Rails4 support which plays nice even with Rails 3
|
👍 Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jtomaszewski, @artembiserov, @dmitrytrager