Skip to content

Commit

Permalink
Change XCODE_WARNING from =TRUE to =1
Browse files Browse the repository at this point in the history
We defined the XCODE_WARNING flag =TRUE but juce defines it =1
in its headers and so with -Werror on macos you would get a
-Wmacro-redefined with JUCE 7. Fix by changing =TRUE to =1
  • Loading branch information
baconpaul committed Jan 29, 2024
1 parent 087dd16 commit 1946ffd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake/ClapTargetHelpers.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ function(clap_juce_extensions_plugin_internal)
# see: https://forum.juce.com/t/vst-au-builds-fail-after-upgrading-to-xcode-15/57936/43
if( ${CMAKE_CXX_COMPILER_VERSION} VERSION_GREATER_EQUAL "15.0.0" AND ${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "15.1")
target_link_options(${claptarget} PUBLIC "-Wl,-ld_classic")
target_compile_definitions(${claptarget} PUBLIC JUCE_SILENCE_XCODE_15_LINKER_WARNING=TRUE)
target_compile_definitions(${claptarget} PUBLIC JUCE_SILENCE_XCODE_15_LINKER_WARNING=1)
if (${CMAKE_OSX_DEPLOYMENT_TARGET} VERSION_LESS "10.13")
message(STATUS "Changing OSX Deployment Target from ${CMAKE_OSX_DEPLOYMENT_TARGET} to 10.13 for XCode 15")
set(CMAKE_OSX_DEPLOYMENT_TARGET "10.13" CACHE STRING "Minimum OS X deployment target" FORCE)
Expand Down

0 comments on commit 1946ffd

Please sign in to comment.