fixing the conversion between clap and normalized vst3 vaues

free-audio · Sep 5, 2024 · 5516dda · 5516dda
1 parent aed3477
commit 5516dda
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/detail/vst3/parameter.h b/src/detail/vst3/parameter.h
@@ -50,6 +50,10 @@ class Vst3Parameter : public Steinberg::Vst::Parameter
   bool fromString(const Steinberg::Vst::TChar* string, Steinberg::Vst::ParamValue& valueNormalized) const override;
 #endif
 
+  // for asClapValue() and asVst3Value()
+  // regarding conversion and the meaning of stepCount take a look here:
+  // https://steinbergmedia.github.io/vst3_dev_portal/pages/Technical+Documentation/Parameters+Automation/Index.html#conversion-of-normalized-values
+
   inline double asClapValue(double vst3value) const
   {
     if (info.stepCount > 0)
@@ -63,7 +67,7 @@ class Vst3Parameter : public Steinberg::Vst::Parameter
     auto& info = this->getInfo();
     if (info.stepCount > 0)
     {
-      return (clapvalue - min_value) / float(info.stepCount + 1);
+      return floor(clapvalue - min_value) / float(info.stepCount);
     }
     return (clapvalue - min_value) / (max_value - min_value);
   }