Skip to content

Commit

Permalink
Dont public-ify clap-wrapper-compile-options
Browse files Browse the repository at this point in the history
clap-wrapper-shared-details had a PUBLIC of clap-wrapper-compile-options
which leaked a Wall upstream, causing problems using JUCE 8.0.2 and clap
first vst3s.

Ugh
  • Loading branch information
baconpaul committed Sep 28, 2024
1 parent e4bb79e commit 5a8d249
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cmake/shared_prologue.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ function(guarantee_clap_wrapper_shared)
src/detail/clap/fsutil.cpp
src/detail/clap/automation.h
)
target_link_libraries(clap-wrapper-shared-detail PUBLIC clap clap-wrapper-extensions clap-wrapper-compile-options)
target_link_libraries(clap-wrapper-shared-detail PUBLIC clap clap-wrapper-extensions clap-wrapper-compile-options-public)
target_link_libraries(clap-wrapper-shared-detail PRIVATE clap-wrapper-compile-options)
target_include_directories(clap-wrapper-shared-detail PUBLIC libs/fmt)
target_include_directories(clap-wrapper-shared-detail PUBLIC src)

Expand Down

0 comments on commit 5a8d249

Please sign in to comment.