Skip to content

Commit

Permalink
Respond to review feedback; uppercase char[0]
Browse files Browse the repository at this point in the history
  • Loading branch information
baconpaul committed Oct 30, 2024
1 parent f49ee38 commit e73dafc
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/detail/auv2/build-helper/build-helper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,13 @@ struct auInfo
{
of << " <key>tags</key>\n"
<< " <array>\n";
for (const auto &tag : tags)
for (auto tag : tags) // purposefully take a copy so we can mutate case
{
if (tag[0] >= 'a' && tag[0] <= 'z')
{
// Upper case the first char
tag[0] = std::toupper(tag[0]);
}
of << " <string>" << tag << "</string>\n";
}
of << " </array>\n";
Expand Down

0 comments on commit e73dafc

Please sign in to comment.