Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramp up compiler warnings #81

Closed
0ax1 opened this issue Sep 2, 2023 · 3 comments
Closed

Ramp up compiler warnings #81

0ax1 opened this issue Sep 2, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@0ax1
Copy link
Collaborator

0ax1 commented Sep 2, 2023

As of now, the clap-wrapper target uses the default minimum of compiler warnings. In order to catch as many errors as possible at compile time, additional warning groups such as -Wall, -Wextra and -Wpedantic should be considered.

After resolving all warnings for the added groups, we could think about enabling warnings as errors: -Werror.

@baconpaul
Copy link
Collaborator

The next branch turns on wall on gcc and clang and clang has them mostly clear now

@0ax1
Copy link
Collaborator Author

0ax1 commented Sep 8, 2023

landed for clang/gcc in: #109

@defiantnerd defiantnerd added documentation Improvements or additions to documentation enhancement New feature or request solved in next solved in branch "next" labels Sep 8, 2023
@baconpaul
Copy link
Collaborator

we are now -Wall -Wextra -Wpedantic -Werror on gcc and clang. Thanks for raising this.

I suggest we open a separate issue for MSVC and close this one when we make 0.5.0

@defiantnerd defiantnerd removed the solved in next solved in branch "next" label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants