Param To/From string correct in VST3 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
baconpaul
commented
Sep 7, 2023
baconpaul
commented
- A tresult means don't return true false. Because those are false/true respectively.
- The fromString requires a normalized value as the output
- Use the memory guarded copy8 to get the data from a wstring in to value, and no longer copy the unused return value.
1. A tresult means don't return true false. Because those are false/true respectively. 2. The fromString requires a normalized value as the output 3. Use the memory guarded copy8 to get the data from a wstring in to value, and no longer copy the unused return value.
baconpaul
force-pushed
the
strings-work
branch
from
0b17ad8 to
0c2bc25
Compare
baconpaul
added a commit
to baconpaul/clap-wrapper
that referenced
this pull request
Sep 8, 2023
Ignore unused-parameter; it is useful to document intent. Keep the rest If we merge free-audio#107 we will be able to turn on Werror also, at least on mac.
baconpaul
added a commit
to baconpaul/clap-wrapper
that referenced
this pull request
Sep 8, 2023
Ignore unused-parameter; it is useful to document intent, but keep the rest of the warnings. gcc pragma ignore some vst3 headers to get there. If we merge free-audio#107 we will be able to turn on Werror also, at least on mac and linux.
defiantnerd
reviewed
Sep 8, 2023
defiantnerd
pushed a commit
that referenced
this pull request
Sep 8, 2023
Ignore unused-parameter; it is useful to document intent, but keep the rest of the warnings. gcc pragma ignore some vst3 headers to get there. If we merge #107 we will be able to turn on Werror also, at least on mac and linux.
defiantnerd
pushed a commit
that referenced
this pull request
Sep 9, 2023
1. A tresult means don't return true false. Because those are false/true respectively. 2. The fromString requires a normalized value as the output 3. Use the memory guarded copy8 to get the data from a wstring in to value, and no longer copy the unused return value.
defiantnerd
pushed a commit
that referenced
this pull request
Sep 9, 2023
Ignore unused-parameter; it is useful to document intent, but keep the rest of the warnings. gcc pragma ignore some vst3 headers to get there. If we merge #107 we will be able to turn on Werror also, at least on mac and linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.