Enable consistent clang format for the project #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
baconpaul
commented
Sep 10, 2023
baconpaul
commented
- Add a .clang-format which is basically 2 spaces, allman braces, embedded namespaces.
- Reformat the entire codebase with find src -iname ".cpp" -o -iname ".h" -o -iname "*.mm" | xargs clang-format -i
- add a cmake code checks target which currently just checkes that the code remains clang formatted
- Add a github action which runs that code check target on ubuntu on a PR
1. Add a .clang-format which is basically 2 spaces, allman braces, embedded namespaces. 2. Reformat the entire codebase with find src -iname "*.cpp" -o -iname "*.h" -o -iname "*.mm" | xargs clang-format -i 3. add a cmake code checks target which currently just checkes that the code remains clang formatted 4. Add a github action which runs that code check target on ubuntu on a PR
baconpaul
force-pushed
the
clang-format
branch
from
c13c7ea to
06f04d4
Compare
0ax1
reviewed
Sep 10, 2023
.clang-format
Outdated
| IndentWidth: 2 | ||
| AlignAfterOpenBracket: Align | ||
| BreakBeforeBraces: Allman | ||
| ColumnLimit: 250 |
There was a problem hiding this comment.
Do we really wanna turn off automatic line breaks? Kinda hard to work with on a laptop. How about something generous like 105?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.