Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an small example and test of clap-first in-linked wrapper #256

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

baconpaul
Copy link
Collaborator

  • Bring over my c99 distortion and make it C++
  • Show that making all flavors as statically linked
  • add it to CI

@baconpaul baconpaul marked this pull request as draft June 10, 2024 13:41
@baconpaul
Copy link
Collaborator Author

@defiantnerd this is me looking at the compile flags which tripped up matt and at the same time adding a simple 'clap first' test and example with static linking into the compionents. It's a draft because I want to add some doc and also make CI work. I'll tag you when its ready for review.

@baconpaul
Copy link
Collaborator Author

Link to #119 also

- Bring over my c99 distortion and make it C++
- Show that making all flavors as statically linked
- add it to CI
@baconpaul
Copy link
Collaborator Author

This also shows #257 and #258

@baconpaul baconpaul changed the base branch from main to next June 10, 2024 15:33
@baconpaul baconpaul marked this pull request as ready for review June 10, 2024 15:33
@baconpaul
Copy link
Collaborator Author

OK @defiantnerd this is now ready for review

Basically what I did was add a small clap and show it linking statically into each of the wrappers, fixed the wrapper over-exports error problem, added some doc, added it to CI

Doing so showed up two errors in the wrapper which i didn't fix in this commit, but will happily pluck at this week.

Let me know what you think! I'm happy to merge this to next if you are.

@defiantnerd
Copy link
Collaborator

The stepped-bug is not a bug. My guess is that there is a bug in bitwig, but we have to check.

Copy link
Collaborator

@defiantnerd defiantnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok by me, so far I get it. I would merge it and we have a final checkup before merging to main.

@defiantnerd defiantnerd merged commit 0e25b03 into free-audio:next Jun 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants