Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows SA: Total refactor #280

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Windows SA: Total refactor #280

merged 3 commits into from
Aug 17, 2024

Conversation

mthierman
Copy link
Contributor

A complete refactor of the Windows standalone

  • Now using the W versions of the Win32 API instead of A and have disabled UTF8 code page in the manifest, so we don't need to rely on a minimum version of Windows
  • Users can optionally provide a .ico that will display in the titlebar
  • Vendored the Windows Implementation Library to make win32 programming easier (for instance, file dialogs)
  • GUI logic should be more robust, still needs some work
  • Fixed a bug with audio engine crashing (set the audio in/out counts)
  • More correct handling of CL/Clang compiler frontends for entry point
  • Fixed CLAP output_name in the standalone wrapper CMake

@baconpaul
Copy link
Collaborator

So I'm not a windows expert but this looks reasonable to me. Would love @defiantnerd to look

The only thing I'm unsure of is do we want a copy of wil or do we want to CPM it like we do with RTAudio etc...

It is header only so we don't need to compile it in any way, but only grabbing if someone builds windows standalone may be the more symmetric thing to do. Thoughts? May make it more friendly for people being explicit about licenses for sub-components too? Perhaps?

We can also push it to next and change our mind later.

Great stuff!

@mthierman
Copy link
Contributor Author

WIL is now using our guarantee strategy with CPM, and I have fixed some CMake errors and also compiler warnings in /W4.

I've also added more of fmtlib for better logging and improved the GUI code and disabled the WIP settings window.

Copy link
Collaborator

@defiantnerd defiantnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take this to next and then test it a bit deeper. On the first glance, all looks very fine..
Thanks @mthierman

@defiantnerd defiantnerd merged commit d247d4d into free-audio:next Aug 17, 2024
19 checks passed
@mthierman mthierman deleted the windows-standalone-refactor branch September 21, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants