Fix VST3 wrapper in Ardour #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ardour creates and derefences an editor instance without ever showing or parenting it (for the reason of finding out if it supports the apu in VST#PI::has_editor). That's a bit odd, but it also meant that _onDestroy was never called, since that was guarded by _created. So add an _onDestroy which knows if ever created and resets just the pointer if not, allowing windows to not crash in Ardour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ardour creates and derefences an editor instance without ever showing or parenting it (for the reason of finding out if it supports the apu in VST#PI::has_editor). That's a bit odd, but it also meant that _onDestroy was never called, since that was guarded by _created.
So add an _onDestroy which knows if ever created and resets just the pointer if not, allowing windows to not crash in Ardour