Implement SingleComponentEffect::getBusInfo and fix Ardour #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconpaul
force-pushed
the
ardour-multibus-fix
branch
from
979a133 to
1bd2eea
Compare
Ardour uses getBusInfo to set up busses even though later we call setBusInfo, and so as a result didn't recieve the kDefaultActive flag we set when we setup processing. This meant that Ardour would not activate auxilliary busses in multi-out effects so our process loop would find an invalid configuration and not call the clap. Defacto this meant "no sound in shortcircuit xt in the wrapper in ardour". This imsplementation fixes the issue.
baconpaul
force-pushed
the
ardour-multibus-fix
branch
from
1bd2eea to
2b87985
Compare
defiantnerd
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ardour uses getBusInfo to set up busses even though later we call setBusInfo, and so as a result didn't recieve the kDefaultActive flag we set when we setup processing.
This meant that Ardour would not activate auxilliary busses in multi-out effects so our process loop would find an invalid configuration and not call the clap.
Defacto this meant "no sound in shortcircuit xt in the wrapper in ardour". This imsplementation fixes the issue.