macOS standalone request_callback timer #294
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does much the same as the windows PR, but with objc timers - objc isn't my strong suit, so any sanity checking appreciated.
Also, my previous PR for the
applicationShouldTerminateAfterLastWindowClosed
implementation inadvertently led to a segfault on close, when we reached the section ofapplicationWillTerminate
where the window stuff is freed. According to the docs,[window close]
by default calls[window release]
, so my working theory is that it was leading to a double free when closed that way.To fix it, I implemented
windowWillClose
, and set the window member tonil
there. Then inapplicationWillTerminate
, I check ifself.window=nil
, and if it isn't, call[[self window] release]
, and that seems to have fixed it!