Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CFRelease() calls in host_get_name() #306

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

directmusic
Copy link
Contributor

In the Core Foundation functions any time the word "Get" is used we do not have ownership and do not need to call CFRelease(). Fixes #304

https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html#//apple_ref/doc/uid/20001148-SW1

@baconpaul
Copy link
Collaborator

baconpaul commented Sep 8, 2024

formatting aside (and that it came from main not next so blew out a tiny formatting change on next) this change looks correct to me. I may tweak it a touch tomorrow to fix formatting and remove the string change I had made on the hostname. but @defiantnerd wdyt?

And thanks @directmusic.

@defiantnerd we should review the rest of the AUV2 code to make sure we aren't making a similar error elsewhere.

@baconpaul
Copy link
Collaborator

Actually had a moment before end of day and pushed up a clang format fix and also the regression of next vs main

if CI passes lets ask @defiantnerd to look.

Thank you!!

@defiantnerd
Copy link
Collaborator

Yeah, fix is fine. Thank you very much, @directmusic !
And yes, we should give AUv2 another review for this issue.

@defiantnerd defiantnerd merged commit 90b16c5 into free-audio:next Sep 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants