Windows SA: Audio/MIDI settings #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #188. |
baconpaul
reviewed
Sep 20, 2024
src/detail/standalone/entry.cpp
Outdated
| @@ -75,6 +76,7 @@ std::shared_ptr<Clap::Plugin> mainCreatePlugin(const clap_plugin_entry *ee, cons | |||
| if (fs::exists(loadPath / "settings.clapwrapper")) | |||
| { | |||
| LOG << "Trying to load from clap wrapper settings" << std::endl; | |||
| fs::create_directories(loadPath); | |||
There was a problem hiding this comment.
This creat isn't needed since we already know the directory exists from the if above
There was a problem hiding this comment.
Good catch, I forgot we were loading here.. Removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the semi-crazy diff.
I have tried to be as minimally invasive to the standalone host to implement changing audio ins/outs, buffer sizes & sample rates, and MIDI devices. This should be double checked against the mac and linux versions for any breakage but the behavior should be the same on those platforms.