replacing insufficient VST3 SDK conversion with proper version. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2024 10:44
defiantnerd
commented
Sep 25, 2024
src/wrapasvst3.cpp
Outdated
|
|
||
| auto src = reinterpret_cast<const uint8_t*>(utf8string); | ||
| size_t pos = 0; | ||
| while (src[pos] && (targetpos < (targetsize - 1))) |
There was a problem hiding this comment.
(targetsize -2) because a character and NUL must have room.
baconpaul
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
This all looks fine to me. The only question is are we sure Steinberg::char16 and uint16_t are always the same type.
I would be tempted to add somewhere
static_assert(std::is_same_v<Steinberg::char16, uint16_t>);
just in case an API shifts underneath us. But glad to hear why we don't need that too!
|
The parameter names were displayed correctly when I tried building with the code here!! Please continue with the parameter values as well! Once again, thank you all for working on this problem! |
|
Just checked in that values and bus names are also correctly converted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #305