Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows standalone: Fix NOMINMAX #313

Merged
merged 1 commit into from
Sep 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions cmake/wrap_standalone.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,13 @@ function(target_add_standalone_wrapper)

target_compile_definitions(${salib} PUBLIC
CLAP_WRAPPER_HAS_WIN32
)

target_compile_definitions(${SA_TARGET} PRIVATE
UNICODE
NOMINMAX
)

set_target_properties(${SA_TARGET} PROPERTIES
WIN32_EXECUTABLE TRUE
OUTPUT_NAME ${SA_OUTPUT_NAME}
)

if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
Expand All @@ -151,8 +149,6 @@ function(target_add_standalone_wrapper)

target_link_libraries(${SA_TARGET} PRIVATE base-sdk-wil ComCtl32.Lib)

set_target_properties(${SA_TARGET} PROPERTIES OUTPUT_NAME ${SA_OUTPUT_NAME})

elseif(UNIX)
target_sources(${SA_TARGET} PRIVATE
${CLAP_WRAPPER_CMAKE_CURRENT_SOURCE_DIR}/src/wrapasstandalone.cpp)
Expand Down
Loading