Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded discussion of -1 wildcard note address mechanism #370

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Expanded discussion of -1 wildcard note address mechanism #370

merged 2 commits into from
Dec 20, 2023

Conversation

baconpaul
Copy link
Collaborator

Explaning how the wildcard voice lookup works

@baconpaul
Expanded discussion of -1 wildcard note address mechanism
3b79854 
Explaning how the wildcard voice lookup works
0ax1
0ax1 approved these changes Dec 18, 2023
View reviewed changes
Copy link

@0ax1 0ax1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 📓 🖊️ !

2 nits inline

include/clap/events.h Outdated Show resolved Hide resolved
include/clap/events.h Outdated Show resolved Hide resolved
@baconpaul
Copy link
Collaborator Author

lgtm 📓 🖊️ !

2 nits inline

thanks - addressed both

@abique
Copy link
Contributor

abique commented Dec 20, 2023

Thank you very much 👍

@abique abique merged commit d865610 into free-audio:next Dec 20, 2023
4 checks passed
@baconpaul baconpaul deleted the note-wildcards branch December 20, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abique abique abique left review comments

@0ax1 0ax1 0ax1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baconpaul @abique @0ax1