Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust latency extension requirements #392

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

Trinitou
Copy link
Contributor

@Trinitou Trinitou commented Feb 7, 2024

proposal after some discussion on Dischord.

  1. Someone reported that Bitwig and Reaper immediately call plugin_latency->get after host_latency->changed gets called from the plugin during activation
    • solution: allow plugin_latency->get to be called already during plugin->activate
  2. I think it does not make sense if host_latency->changed is called before activate.
    • solution: require host_latency->changed to be called only during plugin->activate
    • open question: should it be mandatory for the plugin to call host_latency->changed during activate after setting up its latency internally? (How do existing hosts handle the case that plugins do not call host_latency->changed during activation? Maybe you can tell how Bitwig handles it, @abique?)

Not sure whether the term being-activated is optimal. If you have better suggestions, please feel free to change it or suggest something else.

abique and others added 2 commits January 22, 2024 10:30
- allow plugin_latency->get to be called during plugin->activate
- require host_latency->changed to be called during plugin->activate
@Trinitou Trinitou changed the base branch from main to next February 7, 2024 22:51
@abique
Copy link
Contributor

abique commented Sep 2, 2024

Thanks! 👍

@abique abique merged commit 6332d3b into free-audio:next Sep 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants