Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLAP 1.2.1 #405

Merged
merged 32 commits into from
May 4, 2024
Merged

CLAP 1.2.1 #405

merged 32 commits into from
May 4, 2024

Conversation

abique
Copy link
Contributor

@abique abique commented Apr 23, 2024

No description provided.

baconpaul and others added 23 commits February 19, 2024 10:26
@baconpaul
Documentation: WildCards for PCK not allowed in note on
bcdc1ef 
The NoteOn event needs port/channel/key specified. Add this
fact to the documentation.
@baconpaul
Review feedback: Host or Plugin can ignore event.
9aec0ec
@abique
Merge pull request #394 from baconpaul/noteon-wildcard
e4ef255 
Documentation: WildCards for PCK not allowed in note on
@abique
initial draft on undo v2.0
eb7902a
@abique
clarify undo
546ed7d
@abique
make the delta forward compatible as a requirement
e4c7447
@abique
Add delta format version id and context subscription
f19882c
@abique
add a lifetime info to the undo delta
d902186
@abique
undo: doc
35a97b1
@abique
Add implicit change
f332bce
@abique
Add CLAP_UNDO_DELTA_LIFETIME_VOID
ce78ca6
@abique
doc.
b3ffd50
@abique
doc.
aaf5745
@abique
typo
9fbc411
@abique
complete_change() -> change_made()
ce92aa2
@abique
Simplify the delta properties
27517a5
@abique
subscribe_to_context_info -> set_wants_context_info
92f68fc
@abique
Rule for implicit changes
d1274b8
@abique
Fix bad constant
3cb07ba
@abique
Merge pull request #402 from abique/undo-v2
a10c3ec 
Undo v2.0
@abique
Update version and changelog for 1.2.1
d56a282
@abique
line break
48cd2ba
@abique
changelog entry for events.h
dd8aff3
@baconpaul
Copy link
Collaborator

The content is fine with me, but can we clean up the git transactions a bit? Like, rebase/merge all those undo changes into a single commit in the log?

@abique
Copy link
Contributor Author

abique commented Apr 23, 2024

The content is fine with me, but can we clean up the git transactions a bit? Like, rebase/merge all those undo changes into a single commit in the log?

We'd loose the history if we squash, also the next branch is on the repo and we can't force push, so I'm not sure if it'll help.

I value the history because we keep a record of the thinking process and the various steps the extension went through. It may be useful one day for someone trying to understand why we've made an extension in a certain way.

It is still possible to read a squashed change set by making a diff between tags.

@baconpaul
Copy link
Collaborator

We don’t have to squash. We can partially rebase next to squash some of the interim commits with rebase -I and the do pick and fixup

messmerd
messmerd reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions - mostly typo fixes

@baconpaul
Copy link
Collaborator

Alex: I added info on rebasing on discord if that helps!

abique and others added 9 commits April 24, 2024 10:29
@abique @messmerd
Update include/clap/ext/draft/undo.h
3d91c95 
Co-authored-by: Dalton Messmer <[email protected]>
@abique @messmerd
Update include/clap/ext/draft/undo.h
cb32b0e 
Co-authored-by: Dalton Messmer <[email protected]>
@abique @messmerd
Update include/clap/ext/draft/undo.h
744d987 
Co-authored-by: Dalton Messmer <[email protected]>
@abique @messmerd
Update include/clap/ext/draft/undo.h
f9a6aa2 
Co-authored-by: Dalton Messmer <[email protected]>
@abique @messmerd
Update include/clap/ext/draft/undo.h
e432bb5 
Co-authored-by: Dalton Messmer <[email protected]>
@abique @messmerd
Update include/clap/ext/draft/undo.h
c32173a 
Co-authored-by: Dalton Messmer <[email protected]>
@abique @messmerd
Update include/clap/ext/draft/undo.h
66203e6 
Co-authored-by: Dalton Messmer <[email protected]>
@abique @messmerd
Update include/clap/ext/draft/undo.h
9b58efd 
Co-authored-by: Dalton Messmer <[email protected]>
@abique
rename to set_context_info_subscription()
1dcc744
defiantnerd
defiantnerd approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@defiantnerd defiantnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. 2.0 ist much improved.

baconpaul
baconpaul approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@baconpaul baconpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm happy with this!

@abique abique merged commit f350abd into main May 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messmerd messmerd messmerd left review comments

@baconpaul baconpaul baconpaul approved these changes

@Bremmers Bremmers Bremmers approved these changes

@defiantnerd defiantnerd defiantnerd approved these changes

@robbert-vdh robbert-vdh Awaiting requested review from robbert-vdh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abique @baconpaul @Bremmers @messmerd @defiantnerd