Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding draft extension for host-provided scratch memory #423
Adding draft extension for host-provided scratch memory #423
Changes from 1 commit
757a927
ebfe262
3527890
5e2bd97
86c1681
961be0b
d0f0373
a5790e1
efa821a
48c1ba8
a65ba57
1b1a68e
f2a84b9
06ccabd
5bf4e59
635045c
5006ea2
8df28a3
b7968b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we ever use
size_t
in any other extension? ->uint?_t
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point,
uint32_t
would do the job I think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use uint64_t which is size_t in most of our systems? The host has the option to return no for values out of bounds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a preference for
uint32_t
vsuint64_t
... but Trinitou is right that CLAP doesn't usesize_t
anywhere else, so I don't think we should use it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A scratch size bigger than 4 GB would be problematic I suppose, remember
nthreads * max_scratch_size
.Anyway regardless of the type, many host will likely have their own threshold.
uint32_t
seems sufficient to me, but I'm happy withuint64_t
as well.