Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLAP 1.2.3 #432

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

CLAP 1.2.3 #432

wants to merge 13 commits into from

Conversation

abique
Copy link
Contributor

@abique abique commented Nov 18, 2024

No description provided.

@abique abique force-pushed the next branch 2 times, most recently from 773e346 to 069d784 Compare November 18, 2024 19:32
baconpaul and others added 3 commits November 18, 2024 20:35
* Add a description of the expectation of request_callback timing

Without making a requirement, indicate the intent of the timing.

* Add an apostrophe

* Add host can starve feedback from alex

* more review feedback

* notjusthosts
@abique abique force-pushed the next branch 2 times, most recently from fc4a9c3 to ab54bc5 Compare November 18, 2024 19:46
@abique abique marked this pull request as ready for review November 18, 2024 19:46
@abique abique self-assigned this Nov 18, 2024
Copy link
Collaborator

@baconpaul baconpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments on the location extension.

include/clap/ext/draft/location.h Outdated Show resolved Hide resolved
include/clap/ext/draft/location.h Outdated Show resolved Hide resolved
include/clap/ext/draft/location.h Outdated Show resolved Hide resolved
@baconpaul
Copy link
Collaborator

LGTM also.

Copy link
Contributor

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and suggestions regarding the location extension

include/clap/ext/draft/location.h Outdated Show resolved Hide resolved
include/clap/ext/draft/location.h Outdated Show resolved Hide resolved
include/clap/ext/draft/location.h Outdated Show resolved Hide resolved
include/clap/ext/draft/location.h Show resolved Hide resolved
include/clap/ext/draft/location.h Show resolved Hide resolved
include/clap/ext/draft/location.h Show resolved Hide resolved
include/clap/ext/draft/location.h Show resolved Hide resolved
include/clap/ext/draft/location.h Show resolved Hide resolved
@messmerd
Copy link
Contributor

How much information should a host provide to a plugin through the location extension? Should it provide all the information it can, or only information about the plugin itself?

@abique
Copy link
Contributor Author

abique commented Dec 2, 2024

How much information should a host provide to a plugin through the location extension? Should it provide all the information it can, or only information about the plugin itself?

I'm not sure I understood well your question.

Think that you have a very large project, all you need to know your location is:
/project/track_group[0]/track[3]/device[6]

Here from the root track group, take the third track, then the 6th device and here we are.

Does that clarify the question?

abique and others added 3 commits December 19, 2024 16:41
added zig bindings to language bindings section.
@abique
Copy link
Contributor Author

abique commented Dec 19, 2024

I've squashed some changes to the scratch-memory for max_concurrency_hint, and simplified the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants