Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing modify subscription request #41

Merged

Conversation

donald1218
Copy link

@donald1218 donald1218 commented Aug 13, 2024

Description

In the TS 29.518 api_event, the modification involves AmfUpdateEventSubscriptionItem or AmfUpdateEventOptionItem.

Neither the R15 nor the R17 specifications define the ModifySubscriptionRequest data type.

When referring to the R15 version of the OpenAPI, the request data encapsulates them into the request.

  • TS29.518 V17.12 p62
    image

  • TS29.518 V17.12 p211
    image

Reference from R15.

  • In TS29 518 V15.2 p103
    image
  • openapi main (R15)
    image

@andy89923 andy89923 requested a review from ianchen0119 August 13, 2024 08:01
@ianchen0119 ianchen0119 merged commit 9d5721a into free5gc:feat/r17 Aug 14, 2024
1 check passed
@donald1218 donald1218 deleted the fix/missing-modifysubscriptionreq branch August 15, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants