-
-
Notifications
You must be signed in to change notification settings - Fork 379
chore: move to use vite as devtool #929
chore: move to use vite as devtool #929
Conversation
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected] |
b8d3db4
to
114a656
Compare
Hey @shootermv ! I was able to fork your copy of the project. ![]() So I tried my own github pages build of the project and the build failed due to issues with the Also, I was googling around and for the Since this is a migration, we will have to test actual builds of test sites to make sure that this PR doesn't accidentally break the production site. Hope that helps 👍 |
Sorry, totally my bad! |
After looking at the tutorials you sent - i changed deployment script and was able to deploy to my gh-pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to play around with it locally and left a few comments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to do a build and preview locally and it was working on my end.
So we should be good to go.
I vote we merge this in and see if the build goes through. 👍
Then if there are any issues, we can always roll back a commit to the old version and debug from there and try again 👍
I would suggest holding off on deleting this branch until we know the production build worked out
Totally agree |
Summary of changes
migrate project to use vite devtool because it more modern tool for react projects
Checklist
closes #928