-
-
Notifications
You must be signed in to change notification settings - Fork 359
As an owner or chapter admin I can cancel events and all participants who have RSVP'd will get an email notification. #100
Comments
Linking these for when someone starts working on email sending. #283 #146 are related to the transactional email needed to send over SMTP. Also, some questions which may be relevant were raised in #320 (comment) |
This would apply to other bulk email sending as well, but the current default shows / exposes multiple recipients email addresses in the To: line in Mailhog. We'd obviously want a BCC: for any bulk email sending. It was suggested in #909 (comment) to
|
Hi, Is the remaining task only changing the body text of the email that get sent when cancelling an event? |
I think @gikf has worked on a lot of the interface side, so I'm pinging and directing that question accordingly. |
Yep, from more immediate things - I believe so. I think test for it might need changing later, once seeding will seed also unsubscribed users. |
Is there an email content decided? Or do I alter another email content for now, and we can think of one post MVP? |
@Sboonny is the test you mentioned updated? If it is, could you close this? |
Nope, but I think we are done with the MVP part, we can open new issue for test. |
Okay, cool. Could you take care of that? I think you know best what still needs to be done. |
Of course, I wanted to go over it again 👍 |
There is a test for sending the email, but there is no test for the ability to send email when canceling an event "no RSVP", because cypress doesn't create an empty event. Here is the test for sending the event, if you want to check it https://github.com/freeCodeCamp/chapter/blob/1c904645008c0fe649ef474b3f1ee0d0fe12fcf7/cypress/e2e/dashboard/events/events-index.cy.ts#L165-L201?plain=1 I think this is good to go, because the ability to cancel an Event with no member in it is related to the function, but not the issue 👍 |
Great, thanks for looking into this. Canceling events without members seems to be working at the moment, so this can be closed. |
The UI exists and emails get sent, but we still need text for the email.
Depends on #814
Once that is done, we should lock this down to the approved roles and confirm via Cypress tests
The main thing to check is that requests from unauthorised users fail, but it's also helpful to confirm that the UI reflects their role.
Test should account for developer typing logic, that stop canceling the event if there are no members in the event Reference #1517 (comment)
Test should account for the mutation deletion reference #1517 (comment)
The text was updated successfully, but these errors were encountered: