Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

As an owner or chapter admin I can cancel events and all participants who have RSVP'd will get an email notification. #100

Closed
5 tasks done
QuincyLarson opened this issue Oct 20, 2019 · 12 comments
Assignees
Labels
Email MVP UI/UX This issue deals with UI/UX

Comments

@QuincyLarson
Copy link
Contributor

QuincyLarson commented Oct 20, 2019

The UI exists and emails get sent, but we still need text for the email.

Depends on #814

Once that is done, we should lock this down to the approved roles and confirm via Cypress tests

  • As an owner I can cancel any event
  • As an admin of a Chapter I can cancel any events in that Chapter
  • As any other role, I cannot cancel events
  • Sensible email content
  • update the test for it

The main thing to check is that requests from unauthorised users fail, but it's also helpful to confirm that the UI reflects their role.


Test should account for developer typing logic, that stop canceling the event if there are no members in the event Reference #1517 (comment)
Test should account for the mutation deletion reference #1517 (comment)

@vkWeb vkWeb added the Help Wanted Extra attention is needed label Oct 24, 2019
@QuincyLarson QuincyLarson changed the title As an organizer I can cancel events and all participants who have RSVP'd will get an email notification. API: As an organizer I can cancel events and all participants who have RSVP'd will get an email notification. Nov 30, 2019
@QuincyLarson QuincyLarson removed the Help Wanted Extra attention is needed label Nov 30, 2019
@QuincyLarson QuincyLarson changed the title API: As an organizer I can cancel events and all participants who have RSVP'd will get an email notification. As an organizer I can cancel events and all participants who have RSVP'd will get an email notification. Feb 11, 2020
@allella
Copy link
Contributor

allella commented Feb 17, 2020

Linking these for when someone starts working on email sending.

#283 #146 are related to the transactional email needed to send over SMTP.

Also, some questions which may be relevant were raised in #320 (comment)

@allella
Copy link
Contributor

allella commented Feb 21, 2022

This would apply to other bulk email sending as well, but the current default shows / exposes multiple recipients email addresses in the To: line in Mailhog.

We'd obviously want a BCC: for any bulk email sending.

It was suggested in #909 (comment) to

automatically handled by MailerService - depending if submitted email list has more than one entries. But either way that's for another PR.

@ojeytonwilliams ojeytonwilliams changed the title As an organizer I can cancel events and all participants who have RSVP'd will get an email notification. As an owner or chapter admin I can cancel events and all participants who have RSVP'd will get an email notification. May 13, 2022
@Ismailtlem
Copy link
Member

Ismailtlem commented Jun 1, 2022

Hi,

Is the remaining task only changing the body text of the email that get sent when cancelling an event?

@allella
Copy link
Contributor

allella commented Jun 2, 2022

I think @gikf has worked on a lot of the interface side, so I'm pinging and directing that question accordingly.

@gikf
Copy link
Member

gikf commented Jun 2, 2022

Yep, from more immediate things - I believe so.

I think test for it might need changing later, once seeding will seed also unsubscribed users.

@Sboonny
Copy link
Member

Sboonny commented Sep 8, 2022

Is there an email content decided? Or do I alter another email content for now, and we can think of one post MVP?

@ojeytonwilliams
Copy link
Contributor

@Sboonny is the test you mentioned updated? If it is, could you close this?

@Sboonny
Copy link
Member

Sboonny commented Dec 13, 2022

Nope, but I think we are done with the MVP part, we can open new issue for test.

@ojeytonwilliams
Copy link
Contributor

Okay, cool. Could you take care of that? I think you know best what still needs to be done.

@Sboonny
Copy link
Member

Sboonny commented Dec 13, 2022

Of course, I wanted to go over it again 👍

@Sboonny Sboonny self-assigned this Dec 13, 2022
@Sboonny
Copy link
Member

Sboonny commented Dec 14, 2022

There is a test for sending the email, but there is no test for the ability to send email when canceling an event "no RSVP", because cypress doesn't create an empty event.

Here is the test for sending the event, if you want to check it https://github.com/freeCodeCamp/chapter/blob/1c904645008c0fe649ef474b3f1ee0d0fe12fcf7/cypress/e2e/dashboard/events/events-index.cy.ts#L165-L201?plain=1


I think this is good to go, because the ability to cancel an Event with no member in it is related to the function, but not the issue 👍

@ojeytonwilliams
Copy link
Contributor

Great, thanks for looking into this. Canceling events without members seems to be working at the moment, so this can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Email MVP UI/UX This issue deals with UI/UX
Projects
None yet
Development

No branches or pull requests

7 participants