-
-
Notifications
You must be signed in to change notification settings - Fork 359
feat: send emails to rsvps on event cancel #842
feat: send emails to rsvps on event cancel #842
Conversation
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about the text for this PR, placeholders are fine for now.
Tests would be great, though!
it('emails interested users when an event is created', () => { |
has some pretty similar logic, so might be worth a look.
One thing I was thinking about was changing RSVPs to be in a single 'state' (Going, OnWaitlist, Cancelled, etc), rather than having multiple boolean states. Something like this: https://dbdiagram.io/d/61d5605b3205b45b73d7b04a Reason being, the RSVP can only be in a single state at once (you can't be on_waitlist and cancelled, say), so I think a single state should be easier to reason about. Since you've just been looking at rsvps, I wondered if you had any thoughts on this.
Sorry for the slight tangent and thanks for working on this!
Thanks for the lead on tests, I'll take a look there. I saw your issue about RSVPs status #783, I'd agree having status as a single field most likely will simplify some things and help avoid some awkwardness. Like determining if somebody is confirmed/going by checking both on_waitlist and cancelled. |
No problem, thanks for taking a look.
Cool, I wasn't sure if you'd have seen that, since there's been a lot of discussion. Anyways, it's not something to worry about here, but I appreciate the feedback. |
7f5e739
to
e791389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, @gikf. This LGTM 👍
Update README.md
).main
branch of Chapter.Still required:
Related to #100
Draft adding sending emails to rsvps when event is cancelled.
cancelled: true
, but this doesn't seem to be displayed in the client right now.user.user_event_roles
, but as that's going to be handled by authorization I've removed it.