This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: cancel event email content #1517
chore: cancel event email content #1517
Changes from 12 commits
5d02192
b8f019f
ee94fe7
d2ef1eb
600f475
6a471ea
290c43b
a6126b7
0620983
3bd23b3
16de043
4ee6854
bce7345
b582327
66a3337
2e7c4da
f157474
28dd217
ae35156
35611a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use
getEventUnsubscribeOptions
(and beunsubscribeOptions
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is complicated because this cancel RSVP without userId, so if we are using
getEventUnsubscibeOptions
, we will force user to log inThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move the text to the resolver with comment of why we are doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't force users to login when they want to unsubscribe from email notifications. Fortunately, there's no need to. We have access to the userId via
event_users
. Since each email is different (different unsubscribe tokens) you can usebatchSender
to send them all. There's an example of that insendEventInvite
.