Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

feat: email magic link in development #634

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

ojeytonwilliams
Copy link
Contributor

  • feat: send the magic link via email
  • feat: wrap the link in an anchor tag

With #445 in mind, this makes the login process a little more natural.

@gitpod-io
Copy link

gitpod-io bot commented Jun 22, 2021

@ojeytonwilliams
Copy link
Contributor Author

Just to clarify, this should make the dev experience a bit smoother and provide a fallback for the demo. The plan is still to provide Google auth for the demo and a few more options for the MVP.

Copy link
Member

@Zeko369 Zeko369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mix resolvers into resolvers, create a new service here

server/controllers/Auth/resolver.ts Outdated Show resolved Hide resolved
@ojeytonwilliams
Copy link
Contributor Author

ojeytonwilliams commented Jun 24, 2021

I wouldn't mix resolvers into resolvers, create a new service here

Thanks, I wasn't entirely confident this was right. Is the point that resolvers should just be concerned with handling GraphQL queries/mutations?

@Zeko369
Copy link
Member

Zeko369 commented Jun 24, 2021

Yup, when you annotate a class with @Resolver use it only in the typeGraphql context, because other stuff might break (args, ctx, other decorators)

@Zeko369 Zeko369 merged commit 39aa631 into freeCodeCamp:master Jun 24, 2021
@ojeytonwilliams ojeytonwilliams deleted the feat/email-magic-link branch June 24, 2021 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants