Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add playwright testing #129

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

a2937
Copy link
Member

@a2937 a2937 commented May 21, 2024

Checklist:

Closes #XXXXX

Adds Playwright testing to our repository. It's a fairly simplistic test for now.

@a2937 a2937 requested a review from a team as a code owner May 21, 2024 14:52
@raisedadead raisedadead requested a review from a team May 21, 2024 15:25
@a2937
Copy link
Member Author

a2937 commented May 21, 2024

Here's the page for how to set up the workflow. This might be useful to help get the ideal configuration. https://playwright.dev/docs/ci-intro

@a2937
Copy link
Member Author

a2937 commented May 21, 2024

I'm going to need a little help here. It seems like the web server isn't starting up in the CI but it is locally and I'm not sure what the problem is.

@naomi-lgbt
Copy link
Member

Looks like you got it working?

@a2937
Copy link
Member Author

a2937 commented May 21, 2024

So I did. I wasn't actually sure if it would work.

.github/workflows/playwright.yml Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
@raisedadead raisedadead force-pushed the feat/add-playwright-testing branch 2 times, most recently from bc3c92c to 34fdcc5 Compare May 23, 2024 15:32
Copy link

socket-security bot commented May 23, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

.github/workflows/playwright.yml Outdated Show resolved Hide resolved
@raisedadead
Copy link
Member

Can we add some progress, and the interactive mode similar to the main repository. When I run the command locally, it doesn't "appear" to do anything.

@raisedadead
Copy link
Member

If you need more help please drop the @freeCodeCamp/dev-team a message. Someone should be able to guide you more in the chat.

@a2937 a2937 requested a review from raisedadead May 23, 2024 17:50
@raisedadead
Copy link
Member

image

playwright.config.ts Outdated Show resolved Hide resolved
@a2937 a2937 requested a review from raisedadead May 28, 2024 17:10
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@a2937 a2937 requested a review from naomi-lgbt May 29, 2024 00:37
@raisedadead
Copy link
Member

Thanks for the updates @a2937 !

@Sembauke Can you give this a look since you have expertise in E2E testing? This PR essentially aims to be a "setup" PR to have Playwright similar to the fCC repo. Do you think anything should be improved?

Thanks.

@raisedadead raisedadead merged commit 4e12f79 into freeCodeCamp:main Jun 17, 2024
3 checks passed
@a2937 a2937 deleted the feat/add-playwright-testing branch June 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants