Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsboot: fix misuse of the phrase zpool #1569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

grahamperrin
Copy link
Contributor

A pool is not a zpool.

Consistent with fixes in doc 1fb34fa0530a for
https://bugs.freebsd.org/257405

@grahamperrin grahamperrin marked this pull request as ready for review January 10, 2025 18:05
usr.sbin/bsdinstall/scripts/zfsboot Outdated Show resolved Hide resolved
Copy link
Contributor Author

@grahamperrin grahamperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsdjhb I guess, plural here too. For consistency.

@@ -1007,7 +1007,7 @@ zfs_create_diskpart()
f_eval_catch $funcname gpart "$GPART_CREATE" BSD ${disk}s1 ||
return $FAILURE

# NB: zpool will use s1a (no labels)
# NB: ZFS pool will use s1a (no labels)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# NB: ZFS pool will use s1a (no labels)
# NB: ZFS pools will use s1a (no labels)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants