Fixed EFI loader for UGA protocol #1584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stand/efi/loader/framebuffer.c - Fixed getting EFI framebuffer settings for UGA protocol. - Added Apple MacBookPro3,1 framebuffer parameters for 17" model with 1680x1050 screen. stand/efi/libefi/efi_console.c - Disabled switching to UGA graphics since UGA graphics protocol is broken. stand/efi/loader/bootinfo.c - Added 'no framebuffer found' message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
FreeBSD Rel. 13.0, EFI boot on anApple MacBookPro3,1 17", NVidia GeForce 8600M GTwith UGA graphics ends with a black screen, after display of the 'Start @' message. Most probably this is the case for any machine with EFI/UGA.Looking into the code,
framebuffer.c/efi_find_framebufferreturned with error when no GOP graphics was found, instead of continuing with probing UGA graphics.Furthermore, switching to the now detected UGA graphics blanked the screen until the kernel took over. UGA graphics code in the loader seems to be buggy and may need to be investigated.
Until then, a patch is introduced in
efi_console.c/cons_update_modeto use text mode in this case.CHANGES:
stand/efi/loader/framebuffer.c:
stand/efi/libefi/efi_console.c:
stand/efi/loader/bootinfo.c: