Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Fedora 39 support #1000

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Drop Fedora 39 support #1000

merged 2 commits into from
Nov 26, 2024

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented Nov 13, 2024

Drop support for Fedora 39, once it becomes EOL on November 26th.

Closes #999
Refs #211
Refs freedomofpress/maint-dangerzone-pyside6#5

@apyrgio apyrgio changed the title Drop Fedora 39 suppot Drop Fedora 39 support Nov 13, 2024
Copy link
Member

@almet almet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to see all this code go away!

It seems that the build-install-rpm still uses the --download-pyside6 flag, and thus fails.

Other than that, it looks good!

@apyrgio
Copy link
Contributor Author

apyrgio commented Nov 20, 2024

You're right, just sent a fixup.

Copy link
Member

@almet almet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, we can merge it tomorrow. ✨

Drop Fedora 39 support by removing it from our CI and installation
instructions.

Closes #999
There are various place in our release process
(build/installation/release instructions and CI checks) where we make
sure that the FPF-maintained PySide6 package works in Fedora 39. Now
that Fedora 39 is nearing its EOL date, we can remove those.
@almet almet force-pushed the 999-drop-fedora-39 branch from 8bcc9a5 to c899886 Compare November 26, 2024 15:06
@almet almet merged commit c899886 into main Nov 26, 2024
45 checks passed
@almet almet deleted the 999-drop-fedora-39 branch November 26, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Fedora 39
2 participants