Fix wrong container runtime detection on Linux #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almet
force-pushed
the
212-linux-container-runtime-detection
branch
from
c6be85f to
532fd74
Compare
|
Updated, this now looks like this:
This still needs to be more consistent between the different OSes, and probably display the error on other platforms. |
almet
force-pushed
the
212-linux-container-runtime-detection
branch
from
e84c950 to
c073a78
Compare
|
This now looks like this:
|
almet
force-pushed
the
212-linux-container-runtime-detection
branch
from
c073a78 to
8a16be7
Compare
almet
force-pushed
the
212-linux-container-runtime-detection
branch
from
8a16be7 to
9c8d25d
Compare
almet
changed the title
|
While reviewing the issues that should be included in 0.8.0, I found about #193, which is about displaying errors to the end user. I'm now thinking that the code introduced here to display the logs might be put in a sort of component, to be reused on other parts of the client UI. |
almet
force-pushed
the
212-linux-container-runtime-detection
branch
2 times, most recently
from
857553c to
18205ab
Compare
apyrgio
reviewed
Sep 17, 2024
almet
force-pushed
the
212-linux-container-runtime-detection
branch
2 times, most recently
from
bb8bd17 to
933bd7f
Compare
apyrgio
approved these changes
Sep 17, 2024
|
Thanks Alexis, feel free to merge, I guess once the CI is working once more. |
Use "podman" when on Linux, and "docker" otherwise. This commit also adds a text widget to the interface, showing the actual content fo the error that happened, to help debug further if needed. Fixes #212
almet
force-pushed
the
212-linux-container-runtime-detection
branch
from
933bd7f to
c3c7fbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, not ready to be merged.
Fixes #212