Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -e IPA_SERVER_IP=no-update. #640

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

adelton
Copy link
Collaborator

@adelton adelton commented Nov 19, 2024

When an IPv4 address is set using the ipa-server-install's --ip-address parameter and the DNS record gets populated with that value, the current logic in ipa-server-configure-first rewrites that value after the ipa-server-install finishes and then during the subsequent container starts with the current internal IPv4 address of the container. Admins then have to use the IPA_SERVER_IP environment variable to force the value to be left alone.

This PR adds support for IPA_SERVER_IP value no-update, to just leave the DNS records alone during the container startup.

That way, whatever value(s) get set either during the initial ipa-server-install or perhaps manually will not get lost.

@adelton
Copy link
Collaborator Author

adelton commented Nov 19, 2024

Hello @djasa, you've recently contributed #624.

I wonder if the proposed approach in this PR (as an alternative to #617 and #639) would possibly make it easier for your use cases -- be able to disable updates of the IPv4 addresses, and use the general --ip-address approach.

Of course, if you are using the FreeIPA container for some CI setups where you only connect to it from the same host or other containers, the current logic which updates the DNS record to the internal IP address in the container might be fitting your needs best. The PR should not break that functionality.

@djasa
Copy link
Contributor

djasa commented Nov 20, 2024

The IP sync is actually good for my use case but this is surely nice to have.

@adelton adelton merged commit b089cec into freeipa:master Nov 27, 2024
43 of 44 checks passed
@adelton
Copy link
Collaborator Author

adelton commented Nov 27, 2024

Added tests, fixed problem with the Kubernetes Pod definition that was uncovered by those tests, merged.

@adelton adelton deleted the ipa-server-ip-no-update branch November 28, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants