Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt publishing for xcframework uploads #219

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

gabrielittner
Copy link
Member

When the iOS targets are added, creating an xcframework is enabled and our internal publishing plugin is applied, we are now automatically adding a task to zip the xcframework and add the zip to a publication. This makes the set up we already have in one internal project reusable.

Another small change is to allow setting fgp.internalArtifacts.url to a file:// uri for testing. The only change needed for this was to not add the password credentials in that case.

@gabrielittner gabrielittner requested review from a team and kboyarshinov and removed request for a team November 28, 2023 10:05
Copy link
Contributor

@kboyarshinov kboyarshinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gabrielittner gabrielittner merged commit b0536ed into main Nov 28, 2023
@gabrielittner gabrielittner deleted the xcframework-publishing branch November 28, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants