Add AlbumPolicy::Scope & use in ArtistsController#show #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrislo What do you think? Hopefully I haven't messed up the logic this time! 😬 |
I think this is more idiomatic use of Pundit and it simplifies `ArtistsController#show` nicely which will make adding an Atom feed for that action easier. I suspect there's a nicer way to implement the 2nd expression in the `if` statement in `AlbumPolicy::Scope#resolve`, but the one I've gone with seems to result in a sensible number of queries.
floehopper
force-pushed
the
add-album-policy-scope-and-use-in-artists-controller-show
branch
from
af19a6a to
dff58b9
Compare
Thanks, Chris! |
floehopper
deleted the
add-album-policy-scope-and-use-in-artists-controller-show
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is more idiomatic use of Pundit and it simplifies
ArtistsController#shownicely which will make adding an Atom feed for that action easier.I suspect there's a nicer way to implement the 2nd expression in the
ifstatement inAlbumPolicy::Scope#resolve, but the one I've gone with seems to result in a sensible number of queries.