WIP: Don't allow album release date to be in the future

[floehopper]

TODO: We need to decide what to do about the 2 existing albums that this would render invalid.

[floehopper]

@chrislo

There are 2 existing published albums with release dates in the future in production:

Album.published.where('released_at > ?', Time.zone.today).map { |a| [a.artist.slug, a.slug] }
# => [["clive-murray", "love-and-painkillers"], ["elite-panic", "full-cold-moon"]]

• Love and painkillers: February 2, 2024
• Full cold moon: March 5, 2024

I suggest we manually change these release dates to be today's date and email the users to correct them. If they have a good reason for setting the release date in the future, we can think again.

We can then apply the validation in this PR.

And I'd suggest we create a new issue about scheduling publication of an album in the future if you think that might be useful...?

[chrislo]

@floehopper - this looks great. I can't think of a good reason why artists would want to set a release date in the future if there wasn't a way of scheduling the publication on a certain day. That kind of scheduling certainly gets used a lot on Bandcamp with pre-release purchasing and notification to followers when an album is released. (As an aside I think some of that is to do with Bandcamp's charts - gathering a bunch of pre-sales is a way of bumping your chances of appearing in the best sellers lists).

In the case of those two albums, fixing the data and contacting the artists to ask them what they wanted to achieve sounds good.

I think scheduling publication and having a cron job to do that is a good idea! It'll have more value when we have followers and notifications of releases, but it'd be good to do in advance of that too.

[floehopper]

I'm going to do this now.

[floehopper]

All done