Extract card component and improve card styling #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And put it in to the preview template. A card expands to fill the container (e.g. grid cell) it's placed in.
I decided to use the (otherwise empty) `subtitle` field of the component to display the publication status, rather than implement logic to preserve the exisiting behaviour.
In Chad's figma designs he suggested that the size and weight of the album title and subtitle should be increased.
chrislo
force-pushed
the
extract-card-component
branch
from
8670bea to
00bfcc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In his design review Chad suggested increasing the size and weight of the album card text and adding a light shadow as a hover state.
This PR makes those changes by first extracting a ViewComponent for the card and then applying the changes in a single place.
Old
New