Encapsulate invocations inside cardinality and handle Expectaction#throws scenario #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cardinality and invocations go hand-in-hand. So, the target is to move invocations to Cardinality.
Cardinality and invocations go hand-in-hand. So, the target is to move invocations to Cardinality.
The target is to encapsulate it inside Cardinality in a tell-don't-ask style.
The target is to encapsulate it inside Cardinality in a tell-don't-ask style.
expected hadn't quite sounded right because it also included allowed.
Using more expressive & concise conditionals & booleans.
This helps us avoid rescuing an exception raised by code elsewhere in the Mocha code. Also, enables us to handle the missed scenario where Expectaction#throws is called, 'coz without it, we'd need a generic way to catch any thrown tag and that might be quite awkward.
floehopper
commented
Nov 16, 2019
There was a problem hiding this comment.
@nitishr Sorry for the delay. I've now reviewed this. It looks good to me and I plan to fix-up one minor thing myself and then get it merged. Thanks for your work on it and your patience in waiting for me to review it.
Since I'm the "author" of this PR, I'm not allowed to approve it, so I'm just adding this as a comment. However, this won't prevent me from merging it.
floehopper
added a commit
that referenced
this pull request
Nov 16, 2019
Also handles Expectaction#throws scenario. PR: #410 Second bunch of commits from #394. Co-authored-by: Nitish Rathi <[email protected]>
|
Merged in 4470825. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the 2nd set of commits from #394. The 1st set were merged in 00f0540.
@nitishr was the original author of all the commits in this branch. The original motivation came from #178.