Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gemspec description #696

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Improve gemspec description #696

merged 3 commits into from
Dec 24, 2024

Conversation

floehopper
Copy link
Member

@floehopper floehopper commented Dec 8, 2024

This brings the gemspec description more into line with that in the README. Note that the gemspec description is used on rubygems.org.

Closes #692.

@floehopper
Copy link
Member Author

⚠️ The tilde heredoc syntax cannot be parsed by Rubocop's Ruby v2.2 parser, so this is blocked by #695 ⚠️

I just merged #695, so this can now be rebased and hopefully merged.

@floehopper floehopper force-pushed the update-gemspec-description branch 2 times, most recently from 044912f to d436b32 Compare December 24, 2024 14:53
This brings the gemspec description more into line with that in the
README. Note that the gemspec description is used on rubygems.org [1].

Closes #692.

[1]: https://rubygems.org/gems/mocha
@floehopper floehopper force-pushed the update-gemspec-description branch from d436b32 to cc9221e Compare December 24, 2024 14:55
@floehopper
Copy link
Member Author

⚠️ The tilde heredoc syntax cannot be parsed by Rubocop's Ruby v2.2 parser, so this is blocked by #695 ⚠️

I just merged #695, so this can now be rebased and hopefully merged.

Merging #695 only dropped support for Ruby v2.1, i.e. it didn't in itself mean that we should stop using the Ruby v2.2 parser for rubocop linting. So I've decided to use explicit concatenation with backslashes instead of the squiggily heredoc so I can get it merged without having to sort out the linting issue.

@floehopper floehopper merged commit 1fcdb2f into main Dec 24, 2024
16 checks passed
@floehopper floehopper deleted the update-gemspec-description branch December 24, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update description in gemspec
1 participant