-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IndexError: list index out of range in resampler #1117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leandro Lucarella <[email protected]>
llucax
requested review from
ela-kotulska-frequenz
and removed request for
a team
November 25, 2024 15:47
github-actions
bot
added
part:docs
Affects the documentation
part:data-pipeline
Affects the data pipeline
labels
Nov 25, 2024
llucax
changed the title
IndexError: list index out of range
Fix IndexError: list index out of range in resampler
Nov 25, 2024
When awaiting the resamplers to finish resampling, we need to make a copy of the resamplers dict, because new resamplers could be added or removed while we are awaiting, which would cause the results to be out of sync. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Either `mypy` was improved in general or using `zip()` helped it to figure out the type narrowing, but it seems it can now narrow the type of `exceptions` without the need of a cast. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
resampler-out-of-bounds
branch
from
November 27, 2024 11:09
ba57eb1
to
86430a7
Compare
Updated to:
|
ela-kotulska-frequenz
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
part:data-pipeline
Affects the data pipeline
part:docs
Affects the documentation
type:bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When awaiting the resamplers to finish resampling, we need to make a copy of the resamplers dict, because new resamplers could be added or removed while we are awaiting, which would cause the results to be out of sync.
Here is a traceback of an instance of this bug: