[FC-131196]: Add optional tooltip for input field to support AMB device capabilities #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow tooltip for AMB fields Based on the properties passed from unity_
shalini-venkat
changed the title
srivatsan7
approved these changes
Jan 10, 2025
prasanna-vijayan
approved these changes
Jan 10, 2025
vinu-prasad-e1936
suggested changes
Jan 13, 2025
| @@ -119,6 +119,10 @@ $warning-color: $color-casablanca-300; | |||
| background-color: $input-disabled-bg; | |||
| pointer-events: none; | |||
| } | |||
|
|
|||
| &.truncate { | |||
There was a problem hiding this comment.
Shouldnt we add overflow: hidden and white-space: nowrap to show the ellipsis?
There was a problem hiding this comment.
Ellipsis is working, without the overflow: hidden and white-space: nowrap styles being added explicitly.
packages/crayons-core/src/function-components/field-control.tsx
Outdated
Show resolved
Hide resolved
packages/crayons-core/src/function-components/field-control.tsx
Outdated
Show resolved
Hide resolved
vinu-prasad-e1936
approved these changes
Jan 13, 2025
srivatsan7
approved these changes
Jan 15, 2025
prasanna-vijayan
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Business usecase: For AMB Device Capabilities field, need to add tooltip to show the expanded content of the field on hover of the input field value.
Solution: Add provision to show tooltip on hover of the input fields --> Added support for an optional tooltip feature in crayons. Passed props from unity_frontend to the crayons repo, during the form schema construction, for the AMB device capabilities field.
FR link - https://freshworks.freshrelease.com/ws/FC/tasks/FC-131196
User story - https://freshworks.freshrelease.com/ws/FC/tasks/FC-109926
Checklist:
How Has This Been Tested?
1. Tooltip with header and mapped values:
2. Ellipsis shown for overflowing text:
Screen.Recording.2025-01-07.at.10.25.12.AM.mov