Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 filter empty plugins for calculating scroll offset #125

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

friedow
Copy link
Owner

@friedow friedow commented Apr 2, 2024

This fixes the scrolling issue below #114.

Copy link
Collaborator

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works. LGTM.

@friedow friedow self-assigned this Apr 2, 2024
@friedow friedow merged commit 62d1d33 into main Apr 2, 2024
1 check passed
@friedow friedow deleted the fix/scrolling branch April 2, 2024 18:26
@friedow friedow linked an issue Apr 2, 2024 that may be closed by this pull request
@friedow friedow mentioned this pull request Jun 2, 2024
friedow added a commit that referenced this pull request Jun 2, 2024
## Release Notes

### ✨ New Features
* 💄 display bars to visualize cpu core usage by @friedow in
#121
* ✨ `git_repositories`: add `zoxide` integration by @a-kenji in
#111
* ✨ enable font-fallack for all entries by @friedow in
#131
* 🌈 Allow setting colors via configuration by @pinpox in
#141
* 😜 Gitmoji plugin by @friedow in
#144
* 📑 Firefox bookmarks plugin by @friedow in
#133
* 📜 Firefox History by @friedow in
#152

### 🐛 Fixed Bugs
* 🐛 return false when file_name cannot convert to str by @prmadev in
#123
* 🐛 filter empty plugins for calculating scroll offset by @friedow in
#125
* 🐛 Add sort function to plugin trait by @a-kenji in
#124
* 🐛 implement full desktop spec by @friedow in
#120
* 🐛 fix initial sorting in a bunch of plugins by @friedow in
#129
* 🐛: fix suspend command invocation by @a-kenji in
#134

### Maintenance
* 📝 clarify wayland support by @a-kenji in
#105
* 👷 remove magic-nix-cache action by @a-kenji in
#106
* ✏️ Fix a small typo in the Readme by @a-kenji in
#112
* 🚨 Implement various clippy suggestions by @a-kenji in
#113

### New Contributors
* @prmadev made their first contribution in
#123
* @pinpox made their first contribution in
#141

**Full Changelog**:
v1.0.0...v1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPU: running with 16 cores opens the list at the bottom
2 participants