Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "⬆️ Bump iced from 0.10.0 to 0.12.1" #130

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Revert "⬆️ Bump iced from 0.10.0 to 0.12.1" #130

merged 1 commit into from
Apr 15, 2024

Conversation

friedow
Copy link
Owner

@friedow friedow commented Apr 15, 2024 •
edited
Loading

I noticed a negative performance impact after merging this. I'll revert this for now.

Reverts #81

@friedow friedow merged commit 0c1f85b into main Apr 15, 2024
1 check passed
@friedow friedow deleted the revert-81-dependabot/cargo/iced-0.12.1 branch April 15, 2024 13:27
@friedow friedow mentioned this pull request Apr 15, 2024
Merged
friedow added a commit that referenced this pull request Jul 30, 2024
@friedow
⬆️ Bump iced from 0.10.0 to 0.12.1 (#132)
c3a67bd 
After merging #81 I noticed a
performance impact while filtering entries in release builds. This is
why I reverted this change in
#130.

Feature wise this PR works but I would rather stay on the older version
if the new one decreases performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@friedow