🐛 fix centerpiece not being an overlay in some wayland WMs #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to help you with the layershell feature. Thank you for trying to use our crate!
|
Should the keyboard_interactivity be set to Exclusive to always focus on this program? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where centerpiece was treated as a normal window and not a popup in some wayland window managers like Niri. This was fixed by introducing iced_layershell as a dependency which implements the wayland layershell protocol for iced.
We had to revert the builder pattern for the iced application which was introduced with the upgrade to iced 0.13.x because iced_layershell does not support that yet.
Special thanks to @Decodetalkers for jumping in and helping me make this happen.
This resolves #188.