✨ plugins: add $GIT_DIRECTORY_NAME env variable
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the `$GIT_DIRECTORY_NAME` environment variable to the git_repositories plugin. This is useful for setting `app_ids`, or `tmux` session names, for example. I am not sure about error handling here. The unwraps are there because: - We have a git directory, the file name should always succeed. - It should always be valid Utf8. We could return an empty string in an error case, that way scripts might still succeed and fill in a default value.
friedow
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the
$GIT_DIRECTORY_NAMEenvironment variable to the git_repositories plugin.This is useful for setting
app_ids, ortmuxsession names, for example.I am not sure about error handling here.
The unwraps are there because:
We could return an empty string in an error case, that way scripts might still succeed and fill in a default value.