Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ add plugin trait #9

Merged
merged 15 commits into from
Nov 2, 2023
Merged

♻️ add plugin trait #9

merged 15 commits into from
Nov 2, 2023

Conversation

friedow
Copy link
Owner

@friedow friedow commented Oct 28, 2023

No description provided.

@friedow friedow temporarily deployed to cachix October 28, 2023 19:39 — with GitHub Actions Inactive
@friedow friedow temporarily deployed to cachix October 30, 2023 06:44 — with GitHub Actions Inactive
@friedow friedow temporarily deployed to cachix October 30, 2023 16:24 — with GitHub Actions Inactive
@friedow friedow self-assigned this Oct 30, 2023
@friedow friedow requested a review from a-kenji October 30, 2023 16:45
a-kenji
a-kenji approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

client/src/plugin/utils.rs Outdated Show resolved Hide resolved
@friedow friedow temporarily deployed to cachix October 31, 2023 06:23 — with GitHub Actions Inactive
@friedow friedow temporarily deployed to cachix October 31, 2023 20:11 — with GitHub Actions Inactive
@friedow friedow temporarily deployed to cachix October 31, 2023 21:37 — with GitHub Actions Inactive
@friedow friedow temporarily deployed to cachix October 31, 2023 21:48 — with GitHub Actions Inactive
@friedow friedow temporarily deployed to cachix November 1, 2023 07:52 — with GitHub Actions Inactive
@friedow friedow temporarily deployed to cachix November 2, 2023 16:19 — with GitHub Actions Inactive
@friedow friedow merged commit 7b839a6 into main Nov 2, 2023
1 check passed
@friedow friedow deleted the refactor/add-plugin-wrapper branch November 2, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-kenji a-kenji a-kenji approved these changes

Assignees

@friedow friedow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friedow @a-kenji